workadventure

lbehm/workadventure

Fork 0

Commit graph

Author	SHA1	Message	Date
David Négrier	e43c4cd5ae	Fixing a freeze in MapStore on several unsubscribes For some reason (I could not reproduce this in unit tests alas), the unsubscribe function could be called several times in a row, leading to a complete map freeze. Closes #1736	2022-01-28 09:58:24 +01:00
David Négrier	0e68490e75	Refactoring with a MapStore A great deal of the complexity of the current code is that we must chain 2 reactive values (one in the map "GameScene.MapPlayersByKey" and one in the snapshot store). The new generic MapStore class can be used to listen to stores inside a map. When the store inside the map, or the map itself is modified, the resulting store is updated.	2021-12-14 14:47:25 +01:00

Author

SHA1

Message

Date

David Négrier

e43c4cd5ae

Fixing a freeze in MapStore on several unsubscribes

For some reason (I could not reproduce this in unit tests alas), the unsubscribe function
could be called several times in a row, leading to a complete map freeze.

Closes #1736

2022-01-28 09:58:24 +01:00

David Négrier

0e68490e75

Refactoring with a MapStore

A great deal of the complexity of the current code is that we must chain
2 reactive values (one in the map "GameScene.MapPlayersByKey" and one in
the snapshot store).

The new generic MapStore class can be used to listen to stores inside a map.
When the store inside the map, or the map itself is modified, the
resulting store is updated.

2021-12-14 14:47:25 +01:00

2 commits