lbehm/workadventure
1
0
Fork 0
Code Issues Pull requests Releases Activity

Fixing issue if group was deleted when out of bounds.

Browse source
This commit is contained in:
David Négrier 2021-12-24 14:07:29 +01:00
parent fefe7c8aa5
commit d6e8bd522f
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
back/src/Model/GameRoom.ts
View file

@ -312,7 +312,6 @@ export class GameRoom {
} }
group.leave(user); group.leave(user);
if (group.isEmpty()) { if (group.isEmpty()) {
this.positionNotifier.leave(group);
group.destroy(); group.destroy();
if (!this.groups.has(group)) { if (!this.groups.has(group)) {
throw new Error(`Could not find group ${group.getId()} referenced by user ${user.id} in World.`); throw new Error(`Could not find group ${group.getId()} referenced by user ${user.id} in World.`);

4
back/src/Model/Group.ts
View file

@ -141,6 +141,10 @@ export class Group implements Movable {
* Usually used when there is only one user left. * Usually used when there is only one user left.
*/ */
destroy(): void { destroy(): void {
if (!this.outOfBounds) {
this.positionNotifier.leave(this);
}
for (const user of this.users) { for (const user of this.users) {
this.leave(user); this.leave(user);
} }