lbehm/workadventure
1
0
Fork 0
Code Issues Pull requests Releases Activity

setProperty function doesn't set an empty array if property doesn't exist

Browse source
This commit is contained in:
GRL 2021-07-02 14:40:18 +02:00
parent e1611969ce
commit c5b5326480
3 changed files with 5 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
CONTRIBUTING.md
View file

@ -42,7 +42,7 @@ Before committing, be sure to install the "Prettier" precommit hook that will re
In order to enable the "Prettier" precommit hook, at the root of the project, run: In order to enable the "Prettier" precommit hook, at the root of the project, run:
```console ```console
$ yarn run install $ yarn install
$ yarn run prepare $ yarn run prepare
``` ```

6
front/src/Phaser/Game/GameScene.ts
View file

@ -1075,11 +1075,13 @@ ${escapedMessage}
console.warn('Could not find layer "' + layerName + '" when calling setProperty'); console.warn('Could not find layer "' + layerName + '" when calling setProperty');
return; return;
} }
const property = (layer.properties as ITiledMapLayerProperty[])?.find( if (layer.properties === undefined) {
layer.properties = [];
}
const property = (layer.properties as ITiledMapLayerProperty[]).find(
(property) => property.name === propertyName (property) => property.name === propertyName
); );
if (property === undefined) { if (property === undefined) {
layer.properties = [];
layer.properties.push({ name: propertyName, type: typeof propertyValue, value: propertyValue }); layer.properties.push({ name: propertyName, type: typeof propertyValue, value: propertyValue });
return; return;
} }

5
maps/tests/Metadata/setTiles.json
View file

@ -286,11 +286,6 @@
"name":"jitsiTrigger", "name":"jitsiTrigger",
"type":"string", "type":"string",
"value":"onaction" "value":"onaction"
},
{
"name":"jitsiUrl",
"type":"string",
"value":"meet.jit.si"
}] }]
}, },
{ {