qbi/additional_plugins
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

metadesc: Fix logic for INSERT/UPDATE/DELETE. (#99)

Browse source 
Properties where deleted from the database
when the property was present in the database
and it wasn't changed. That seems wrong.

Signed-off-by: Thomas Hochstein <thh@inter.net>
This commit is contained in:
Thomas Hochstein 2019-06-10 18:37:07 +02:00 committed by onli
parent 4057473162
commit 8155626bd6
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
serendipity_event_metadesc/ChangeLog
View file

@ -1,3 +1,7 @@
0.15.4:
-------
* Fix logic for INSERT/UPDATE/DELETE of properties.
0.15.3:
-------
* Fixed access to $entry some more. :)

6
serendipity_event_metadesc/serendipity_event_metadesc.php
View file

@ -25,7 +25,7 @@ class serendipity_event_metadesc extends serendipity_event {
$propbag->add('description', PLUGIN_METADESC_DESC);
$propbag->add('stackable', false);
$propbag->add('author', 'Garvin Hicking, Judebert, Don Chambers');
$propbag->add('version', '0.15.3');
$propbag->add('version', '0.15.4');
$propbag->add('requirements', array(
'serendipity' => '0.8',
'php' => '4.1.0'
@ -242,8 +242,10 @@ class serendipity_event_metadesc extends serendipity_event {
$q = "INSERT INTO {$serendipity['dbPrefix']}entryproperties (entryid, property, value) VALUES (" . (int)$eventData['id'] . ", '" . serendipity_db_escape_string($prop_key) . "', '" . serendipity_db_escape_string($prop_val) . "')";
} elseif ($property[$propkey] != $prop_val && !empty($prop_val)) {
$q = "UPDATE {$serendipity['dbPrefix']}entryproperties SET value = '" . serendipity_db_escape_string($prop_val) . "' WHERE entryid = " . (int)$eventData['id'] . " AND property = '" . serendipity_db_escape_string($prop_key) . "'";
} else {
} elseif (!empty($property[$prop_key] && empty($prop_val)) {
$q = "DELETE FROM {$serendipity['dbPrefix']}entryproperties WHERE entryid = " . (int)$eventData['id'] . " AND property = '" . serendipity_db_escape_string($prop_key) . "'";
} else {
// nothing to do
}
serendipity_db_query($q);