cleanup

front/src/Components/ActionsMenu/ActionsMenu.svelte

@@ -1,9 +1,10 @@
 <script lang="typescript">
     import { fly } from "svelte/transition";
-    import { ActionsMenuData, actionsMenuStore } from '../../Stores/ActionsMenuStore';
+    import { actionsMenuStore } from '../../Stores/ActionsMenuStore';
     import { onDestroy } from "svelte";
 
     import type { Unsubscriber } from "svelte/store";
+    import type { ActionsMenuData } from '../../Stores/ActionsMenuStore';
 
     let actionsMenuData: ActionsMenuData | undefined;
 
@@ -57,7 +58,8 @@
         left: 50%;
         transform: translate(-50%, 0);
         width: 260px !important;
-        max-height: 300px;
+        height: max-content !important;
+        max-height: 40vh;
         margin-top: 200px;
 
         pointer-events: auto;
@@ -66,7 +68,7 @@
         color: whitesmoke;
 
         .actions {
-            max-height: 200px;
+            max-height: calc(100% - 50px);
             width: 100%;
             display:block;
             overflow-x:hidden;

front/src/Phaser/Entity/RemotePlayer.ts

@@ -107,18 +107,6 @@ export class RemotePlayer extends Character implements ActivatableInterface {
                     console.log('HELLO');
                 }
             },
-            {
-                actionName: "Log Goodbye",
-                callback: () => {
-                    console.log('GOODBYE');
-                }
-            },
-            {
-                actionName: "Clear Goodbye Action",
-                callback: () => {
-                    actionsMenuStore.removeAction("Log Goodbye");
-                }
-            },
         ];
     }
 

front/src/Phaser/Game/ActivatablesManager.ts

@@ -91,4 +91,4 @@ export class ActivatablesManager {
             MathUtils.distanceBetween(this.currentPlayer.getPosition(), object.getPosition()),
         );
     }
-}
+}

front/src/Phaser/Game/GameScene.ts

@@ -1802,7 +1802,7 @@ ${escapedMessage}
                 case "RemovePlayerEvent":
                     this.doRemovePlayer(event.userId);
                     break;
-                case "UserMovedEvent":
+                case "UserMovedEvent": {
                     this.doUpdatePlayerPosition(event.event);
                     const remotePlayer = this.MapPlayersByKey.get(event.event.userId);
                     if (remotePlayer) {
@@ -1810,6 +1810,7 @@ ${escapedMessage}
                         this.activatablesManager.deduceSelectedActivatableObjectByDistance();
                     }
                     break;
+                }
                 case "GroupCreatedUpdatedEvent":
                     this.doShareGroupPosition(event.event);
                     break;

front/src/Phaser/Game/OutlineableInterface.ts

@@ -8,4 +8,4 @@ export interface OutlineableInterface {
     pointerOutOutline(): void
     characterCloseByOutline(): void
     characterFarAwayOutline(): void
-}
+}

front/src/Stores/ActionsMenuStore.ts

@@ -42,4 +42,4 @@ function createActionsMenuStore() {
     };
 }
 
-export const actionsMenuStore = createActionsMenuStore();
+export const actionsMenuStore = createActionsMenuStore();

front/src/Utils/CustomTypeGuards.ts

@@ -1,5 +1,5 @@
 import type { OutlineableInterface } from '../Phaser/Game/OutlineableInterface';
 
 export function isOutlineable(object: unknown): object is OutlineableInterface {
-    return (object as unknown as OutlineableInterface)?.getObjectToOutline() !== undefined;
-}
+    return (object as OutlineableInterface)?.pointerOverOutline !== undefined;
+}