From 3f4f2bd24b8f1bd18606210b42db166520ac9c20 Mon Sep 17 00:00:00 2001
From: Jens Kubieziel <jens@kubieziel.de>
Date: Sun, 22 Aug 2021 19:42:07 +0200
Subject: [PATCH] Quoting verbessert

---
 townandmail.sh | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/townandmail.sh b/townandmail.sh
index 559cbac..bd34d60 100755
--- a/townandmail.sh
+++ b/townandmail.sh
@@ -35,7 +35,7 @@
 
 umask=077
 
-PROGRAMM_NAME=$(basename $0)
+PROGRAMM_NAME=$(basename "$0")
 DEBUG=0
 VERBOSITY=0
 NEW_GS=0
@@ -65,7 +65,7 @@ Usage: $PROGRAMM_NAME [-d -g -h -k -o outputfile -v] -i input -m input
         -m inputfile    inputfile with email addresses
         -v              run in verbose mode
 EOF
-exit $1
+exit 1
 }
 
 msg() {
@@ -140,7 +140,7 @@ fi
 # wir schneiden aus beiden eingabedateien die plz und den ort heraus,
 # sortieren die daten, entfernen doppelte einträge und zählen diese.
 
-DATASETS=$(awk -F ',' '{ print $2","$1 }' $OHNE_MAIL $MIT_MAIL | sort -u | wc -l)
+DATASETS=$(awk -F ',' '{ print $2","$1 }' "$OHNE_MAIL" "$MIT_MAIL" | sort -u | wc -l)
 msg "Found $DATASETS unique records."
 
 # zuerst gehen wir duch die datei mit den email-adressen. dabei versuchen
@@ -160,7 +160,7 @@ while IFS=, read -r ort plz mail; do
         echo "$gs,$mail" >>$GS_MAIL
     fi
     echo "$plz,$ort,$mail" >>$TMP_OUT
-done <$MIT_MAIL
+done < "$MIT_MAIL"
 msg "OK"
 msg "$MATCH postalcodes and townname matsches"
 msg "$FAILS postalcode and townname doesnt matchs"
@@ -184,7 +184,7 @@ while IFS=, read -r ort plz ; do
             echo "$plz,$ort,cant get community key" >>$FALLOUT
         else
             mail=$(grep "$gs" $GS_MAIL | cut -d ',' -f 2)
-            if [ -z $mail ] ; then
+            if [ -z "$mail" ] ; then
                 FAILS=$(( FAILS + 1 ))
                 echo "$plz,$ort,cant get email for $gs" >>$FALLOUT
             else
@@ -193,7 +193,7 @@ while IFS=, read -r ort plz ; do
             fi
         fi
     fi
-done <$OHNE_MAIL
+done < "$OHNE_MAIL"
 msg "OK"
 msg "$MATCH community codes successfull matched"
 msg "$FAILS failed"
@@ -207,6 +207,6 @@ printf "%5s records failed.\n" "$fail"
 if [ -z "$OUTPUT" ] ; then
     sort -u $TMP_OUT
 else
-    sort -u $TMP_OUT >$OUTPUT
+    sort -u $TMP_OUT > "$OUTPUT"
 fi